Install cmake to restore lintcheck runs #14514
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
samueltardieu
force-pushed
the
push-kzrzwyqlmutr
branch
3 times, most recently
from
97a78f4 to
6392ebe
Compare
samueltardieu
force-pushed
the
push-kzrzwyqlmutr
branch
from
6392ebe to
88c46ea
Compare
samueltardieu
changed the title
|
r? @flip1995 |
flip1995
approved these changes
Apr 1, 2025
I've updated the description, and I've set a reminder on the second week of May to check if this fix can be removed. |
Alexendoo
approved these changes
Apr 1, 2025
|
Looks like this didn't help with #14397, while it did in the current PR, and the trace shows that |
|
Ah right, some runners are on different image versions it looks like and this PR happened to be on the slightly older one In that case we should remove |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tokio-rustlsrequiresaws-lc-syswhich requirescmake 3.xto be built. This installscmake 3.xfrom the repository, overriding thecmake 4.xinstallation.The situation will be reexamined in a few weeks, as
aws-lc-syswill get a new release in a few days withcmake 4.xsupport. We will then be able to remove this temporary fix.changelog: none
r? @ghost